Add named color iterators and remove phf macro dependency #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #422 +/- ##
==========================================
- Coverage 82.78% 82.61% -0.17%
==========================================
Files 130 130
Lines 20199 20254 +55
Branches 20199 20254 +55
==========================================
+ Hits 16721 16733 +12
- Misses 3340 3383 +43
Partials 138 138
|
CodSpeed Performance ReportMerging #422 will not alter performanceComparing Summary
|
Ogeon
force-pushed
the
named_color_iterators
branch
from
c065d88
to
13c298d
Compare
|
Oops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brushes up the
namedmodule a bit:phf_codegeninstead of the proc macro."name_from_str"feature.Closed Issues